Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default ID is too large for qdrant #1329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Flyfoxs
Copy link
Contributor

@Flyfoxs Flyfoxs commented Mar 22, 2024

The default ID as below is too large for qdrant

https://qdrant.tech/documentation/concepts/points/?q=ExtendedPointId Qdrant supports using both 64-bit unsigned integers and UUID as identifiers for points.

Here is an example of default ID
default-app-id--d5f90c9758d5ab25db9aae87e958bd77a9bcd0d35909a4e9aa3662c896b42961

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • Unit Test
  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

The default ID as below is too large for qdrant

https://qdrant.tech/documentation/concepts/points/?q=ExtendedPointId 
Qdrant supports using both 64-bit unsigned integers and UUID as identifiers for points.

Here is an example of default ID
default-app-id--d5f90c9758d5ab25db9aae87e958bd77a9bcd0d35909a4e9aa3662c896b42961
@LeonieFreisinger
Copy link
Contributor

@Flyfoxs Thanks for taking care of this. Your code change looks good to me. Can you link this issue #1328 in your PR description?
Unfortunately, the test_qdrant/test_add is failing.
@deshraj I ran the same test on the main branch locally. Unfortunately, it is failing there as well. Is this familiar to you? If so, should I open a new issue about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants