Python examples rework #27
Conversation
IgorAnohin
force-pushed
the
pr-python-examples-rework
branch
2 times, most recently
from
4780e06
to
0d1e765
Compare
IgorAnohin
force-pushed
the
pr-python-examples-rework
branch
5 times, most recently
from
b3779ae
to
623df66
Compare
Navio: Navio+ modules Navio2: Navio2 modules Common: common modules Add all modules in __init__ files in each folder
Add function get_navio_version, which return Navio version
Make new module and add this module in __init__ file
Make ADC module for Navio+ and add this module in __init__ file
IgorAnohin
force-pushed
the
pr-python-examples-rework
branch
from
623df66
to
66d83fe
Compare
Make new RCInput module for Navio+ in add this module in __init__ file
Make RCOutput module for Navio+ and add this in __init__ file
Print error message if channel too large
Add root check Add Navio+ entry and auto choice shield
Add Navio+ entry and auto choice shield
All modules for this example now in folders Common
All modules for this example now in Common folder Delete useless import util
Add Navio+ entry and add auto choice shield
Add Navio+ entry and auto choice shield
Add root check Add Navio+ entry and add shield auto choice
IgorAnohin
force-pushed
the
pr-python-examples-rework
branch
from
66d83fe
to
323675f
Compare
Nice to hear! But could you please provide any details or close the PR as is. And, if you approve PR, could you merge it? |
|
I've already approved, but cannot merge. Sorry :( |
Could you mention someone, who can? @staroselskii for example |
|
@vldpro could you please help us here? |
|
@IgorAnohin Could you reformat the code with 4-space indentation? I can't really read this. |
If I use |
I hope it won't take another 7 years. |
I've already pushed. You can check the new code using "Files Changed". Unfortunately, to make a real improvement in the readability of this PR, 1 more PR is required. Only with “black” changes. But I don't have enough time for that. So the current version is all I can do. |
It's already a way better! I think we need to get this work done. These examples have been waiting for 7 years to be merged! I think we need someone who has real power to merge it. |
|
@AlexanderDranitsa could you please help us finish this? |
|
Igor, I'm excited to see this code is getting better and better. I'm not sure if it is good enough, though. At least, I agree with @yashin-alexander, you should probably go for Python 3 now. |
There was a problem hiding this comment.
Good job, @IgorAnohin! Needs some improvements, but they are not critical. As @kobylyanskiy mentioned, there are some conflicts that should be resolved
| self.ledG.write(OFF) | ||
| self.ledB.write(OFF) | ||
|
|
||
| def setColor(self, color): |
There was a problem hiding this comment.
Please, bring the code to PEP8 compliance. I see a lot of camelCase naming here
| def setColor(self, color): | |
| def set_color(self, color): |
| return value[:-1] | ||
| except IndexError: | ||
| print("Channel number too large") | ||
| exit(1) |
There was a problem hiding this comment.
It's a good practice to throw exception on higher level instead of exiting inside utility method
|
It's truly disappointing that the review of this feature has taken nearly 7 years, causing significant slowdown for everyone involved. @dskorykh, I appreciate your attention to this, but we need to find someone with the real power to finish our quest. |
|
This is kind of a joke, but seriously, we need to get this done. Let's find someone who can make things happen! |
Hello!
I reworked python examples. What do you think about this?
Could you review it?