-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Getting Started installation instructions to make PATH setting clearer for less experienced developers #21661
base: main
Are you sure you want to change the base?
Conversation
Update downloads.rst
@@ -50,7 +50,12 @@ GitHub and set them as :term:`active <Active Tool/SDK>`: | |||
./emsdk activate latest | |||
|
|||
# Activate PATH and other environment variables in the current terminal | |||
source ./emsdk_env.sh | |||
source /path/to/emsdk/emsdk_env.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command just above also uses the ./emsdk
syntax.. should we change that too?
source ./emsdk_env.sh | ||
source /path/to/emsdk/emsdk_env.sh | ||
|
||
# Verify PATH. This command should return the full path to your emsdk directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This command should print the full path the emcc compiler withing your emsdk directory"
# Verify PATH. This command should return the full path to your emsdk directory | ||
which emcc | ||
|
||
.. note:: If you're struggling to get the ``emcc`` command working, add ``export PATH="/path/to/emsdk/upstream/emscripten:$PATH"`` to your ``/home/username/.bashrc`` file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
emsdk activate
prints this information, and there is more than one path than you would need to add.
How about: "If you prefer you can update your PATH environment variable yourself. Th emsdk activate
command above will print the pathnames you should add".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable. Thanks.
No description provided.