-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dashboard to design v122 (Part 1) #9896
Open
somebody1234
wants to merge
61
commits into
develop
Choose a base branch
from
wip/sb/dashboard-122
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+3,793
−3,496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots more refactors still need to be done so that both backends are always present
somebody1234
added
CI: No changelog needed
Do not require a changelog entry for this PR.
x-new-feature
Type: new feature request
g-dashboard
labels
May 9, 2024
somebody1234
requested review from
PabloBuchu,
indiv0 and
MrFlashAccount
as code owners
May 9, 2024 07:59
I guess I'll avoid stacking the move to tabs on top of this PR, as this is a big PR so there may be a lot of changes needed. |
4 tasks
2 & 3. should be addressed.
|
on second thought 1 will be left for later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI: No changelog needed
Do not require a changelog entry for this PR.
g-dashboard
x-new-feature
Type: new feature request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Close Update the Dashboard to Newest Design #9886
Incidental changes
Important Notes
None
Code review tips
Testing instructions
Screencasts
dashboard-122.mp4
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.