Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Bump build images -> ae0f60a #34228

Closed
wants to merge 7 commits into from

Conversation

dependency-envoy[bot]
Copy link
Contributor

Created by Envoy dependency bot

Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>

@phlax phlax force-pushed the dependency-envoy/build-image/latest branch from cf22163 to 764b468 Compare May 17, 2024 15:27
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label May 17, 2024
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation

🐱

Caused by: #34228 was synchronize by phlax.

see: more, trace.

"/opt/llvm/lib/clang/14.0.0/include",
"/opt/llvm/lib/clang/16/include",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the layout change in 16 to exclude the minor and patch numbers?

Edit: I just checked and sure enough, the minor and patch numbers are excluded

@moderation
Copy link
Contributor

If going to 16 why not use the latest release in that line of 16.0.6 - https://github.com/llvm/llvm-project/releases/tag/llvmorg-16.0.6 ?

@phlax
Copy link
Member

phlax commented May 18, 2024

If going to 16 why not use the latest release

no prebuilt binaries for what we require

@phlax phlax force-pushed the dependency-envoy/build-image/latest branch from 764b468 to f058536 Compare May 20, 2024 15:23
phlax and others added 4 commits May 20, 2024 17:18
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
- envoy_build_tools -> 711e0d2
- llvm -> 16.0.0

Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>
Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>
@phlax phlax force-pushed the dependency-envoy/build-image/latest branch from f058536 to 02720e6 Compare May 20, 2024 16:19
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Member

phlax commented May 20, 2024

no prebuilt binaries for what we require

actually to be more precise there is prebuilt bins for 18.x - but that was failing when trying to build the asan/msan libs in build-tools - this is an attempt at stepping in the right direction and resolving some of the issues along the way

@phlax
Copy link
Member

phlax commented May 20, 2024

ndk update fails with

 Error: ERROR: /source/mobile/WORKSPACE:98:18: fetching android_ndk_repository rule //external:androidndk: java.io.IOException: The repository's path is "/.android/sdk/ndk/27.0.11718014-beta1" (absolute: "/.android/sdk/ndk/27.0.11718014-beta1") but a symlink could not be created for it, because: /.android/sdk/ndk/27.0.11718014-beta1 (No such file or directory)

not 100% but it looks like the android sdk/ndk installer has changed and requires multiple license accepts so current ...

$ echo 'y' | install_ndk_code

fails to install as the license is not accepted

phlax added 2 commits May 20, 2024 18:32
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax closed this May 20, 2024
@phlax phlax deleted the dependency-envoy/build-image/latest branch May 20, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants