Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny fix in automation.h - unused return value removed #6760

Merged
merged 2 commits into from
May 20, 2024

Conversation

latonita
Copy link
Contributor

What does this implement/fix?

add_action() method in the template has return value, but it neither returned nor used.
Just replaced it with void

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes esphome/issues#5385

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@latonita latonita marked this pull request as ready for review May 20, 2024 13:02
@latonita latonita requested a review from a team as a code owner May 20, 2024 13:02
@latonita latonita changed the title Minor fix in automation - remove return value Tiny fix in automation.h - unused return value removed May 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.09%. Comparing base (4d8b5ed) to head (b2afcd4).
Report is 644 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6760      +/-   ##
==========================================
+ Coverage   53.70%   54.09%   +0.38%     
==========================================
  Files          50       50              
  Lines        9408     9627     +219     
  Branches     1654     1701      +47     
==========================================
+ Hits         5053     5208     +155     
- Misses       4056     4092      +36     
- Partials      299      327      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesserockz jesserockz merged commit ce6dc04 into esphome:dev May 20, 2024
55 checks passed
@latonita latonita deleted the autom_small_fix branch May 21, 2024 10:10
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

automation.h wrong return types in functions
3 participants