fix(dallas): make recovery time for 1-bit equal to that of 0-bit #6763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Without this detection of DS18B20 sensors attached along a 10 meter wire fails on an ESP32-C3 (Wemos C3 pico). 58 μs also works when on 5V, on 3.3V however it starts to become unpredictable and fail somewhere between 1/3 and 2/3 of the time.
FYI: I've got 6 sensors in total for my setup. Soldered equidistant along a single cable (3 wires) of about 10m long. Tested both by powering from the board's 3V3 pin as well as the 5V pin. In both cases the data line had a single 4.7 kΩ pull-up resistor between the data and positive power line. (I've tried 2.2 kΩ @ 5V too before writing this patch, it didn't make a difference).
Types of changes
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: