Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[waveshare_epaper] Add color support for 7.5in #6767

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

gumulka
Copy link
Contributor

@gumulka gumulka commented May 18, 2024

What does this implement/fix?

The 7.5in displays are available in a red and yellow variant, but we normally only have support for red, so this is the red support for the 7.5in. If it has yellow, then everything painted red will be shown in yellow.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3844

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

The 7.5in displays are available in a Red and yellow variant, but we
normally only have support for red, so this is the red support for
the 7.5in. If it has yellow, then everything painted red will be
shown in yellow.

Signed-off-by: Fabian Pflug <fabian.pflug@gumulka.eu>
@probot-esphome
Copy link

Hey there @clydebarrow, mind taking a look at this pull request as it has been labeled with an integration (waveshare_epaper) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.13%. Comparing base (4d8b5ed) to head (55fbfbd).
Report is 627 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6767      +/-   ##
==========================================
+ Coverage   53.70%   54.13%   +0.42%     
==========================================
  Files          50       50              
  Lines        9408     9619     +211     
  Branches     1654     1698      +44     
==========================================
+ Hits         5053     5207     +154     
- Misses       4056     4086      +30     
- Partials      299      326      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants