esp-rfid v2 #605
Open
esp-rfid v2 #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended MQTT support
Wiegand Keypad support
Logfile fixes part 1
remove BSSID, speed up wifi connect
ISR IRAM fix and compatibility with esp 2.2.3
Logfile fixes part2
|
I've also create a release to help trying it out, here: https://github.com/esprfid/esp-rfid/releases/tag/2.0.0.rc0 |
|
This is huge 🥳 and puts a great milestone to the project thanks to all efforts you put into this, much appreciated. |
|
Thank you @omersiar! Meanwhile I've deployed it on our system at the local Fablab and found a little bug about the old config compatibility :) If you can approve again would be nice :) I'll leave the PR open for a couple weeks just in case I find anything else or if anyone testing finds any issue. Thank you Omer!! |
Better version built on existing idea
Update rfid.esp
RFID uid fix
deserializeJson needs size if it's not a zero-terminated string
(accountTypes[0] == ACCESS_GRANTED) will always be true if we got this far
Commits abd0e66 and 20e4dcb fixed how UIDs are converted to strings. Previously some '0's in the UID would be missed, meaning the old stored UIDs were actually incorrect. This had the effect of meaning esp-rfid v2 is not compatible with all users from v1. To fix this we create UIDs at scan time in both the new (fixed) format and the old (broken) format, and check the database for both.
don't process JSON past the end of the buffer
Fix activation logic for extra relays
Use correct label for extra relays when editing user
Ensure users are compatible between v1 and v2
helps us mere mortals can understand what's happening :) also quote username in debug output for clarity
Couple of small updates to rfid.esp and add more comments
Fix for NTP blocking loop if connection is blocked
Doesn't keep the door open for 10 seconds!
Fix opening door while disconnected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's time to release a V2 for esp-rfid :)
We need a V2 as there are a few breaking changes on the MQTT interface, but I think it's much better now.
Apart from that, the update from V1 should just work, the old configuration will work on the V2 and the new stuff should default to settings that should keep the old configuration working. If anyone has problems upgrading let me know!
I have updated all the documentation and apart from a merge with stable and a changelog update we should be ready!!
@omersiar let me know what you think :)