Fix access logs and visualization #632
Open
+40
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 23, 2024
Access logs were missing a lot of access denied, which are now added and the UI was displaying only the role of the person trying the access, not the actual result. So now we are logging the card, the role and the result of the opening. For example a standard card could have failed because it has expired, it's disabled or it's outside of the opening hours. In all these cases we should add a line in the access logs saying that the person with the specific role had a denied access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access logs were missing a lot of access denied, which are now added and the UI was displaying only the role of the person trying the access, not the actual result.
So now we are logging the card, the role and the result of the opening.
For example a standard card could have failed because it has expired, it's disabled or it's outside of the opening hours. In all these cases we should add a line in the access logs saying that the person with the specific role had a denied access.