Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMTChecker: Remove UnderOverflow verification target for BMC engine #15105

Merged

Conversation

pgebal
Copy link
Collaborator

@pgebal pgebal commented May 15, 2024

Refactor. Use Overflow and Underflow verification targets instead of OverUnderflow verification target introduced earlier for convenience. That simplifies code in BMC engine.

@pgebal pgebal force-pushed the smtchecker/refactor_bmc_targets_code branch from 7e29e01 to 6f0918e Compare May 15, 2024 16:00
@pgebal pgebal added this to To Do in SMT Checker via automation May 15, 2024
@pgebal pgebal changed the title Remove UnderOverflow verification target for BMC engine SMTChecker: Remove UnderOverflow verification target for BMC engine May 15, 2024
@pgebal pgebal moved this from To Do to In Progress in SMT Checker May 15, 2024
@pgebal pgebal force-pushed the smtchecker/refactor_bmc_targets_code branch from 6f0918e to 3b6bd26 Compare May 16, 2024 14:06
@pgebal pgebal force-pushed the smtchecker/refactor_bmc_targets_code branch from 3b6bd26 to 887a650 Compare May 21, 2024 09:43
@pgebal pgebal marked this pull request as ready for review May 21, 2024 09:44
Copy link
Contributor

@blishko blishko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@pgebal pgebal force-pushed the smtchecker/refactor_bmc_targets_code branch from 887a650 to 6de1680 Compare May 23, 2024 13:10
@blishko blishko merged commit 3251a03 into ethereum:develop May 23, 2024
71 of 72 checks passed
SMT Checker automation moved this from In Progress to Done May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
SMT Checker
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants