fix: undo/redo when exiting view mode #8024
Merged
+1,050
−455
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the bug: When exiting view mode the undo/redo buttons are disabled even though their stacks aren't empty.
Fix
Fixes #7948.
The default constructor is getting called which has values
isUndoStackEmpty
equal totrue
andisRedoStackEmpty
equal totrue
.Passing the function(from class
History
) which checks for whether the stacks are empty or not fixes the issue.Comparison
Before
before.mp4
After
after.mp4