Upgrade To THREE 0.162.0, upgrade to Expo SDK 50 #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(this was automatically done by yarn)
# Conflicts: # example/app/spinning-cubes.tsx # example/package.json # example/yarn.lock
Should Fix expo#164
|
Great work guys! Let's get this merged please @keith-kurak |
|
thanks |
|
This is great stuff! Would love to see it merged. |
|
Any updates on this? This really needs to be merged, |
|
Ooof, I really need this too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the culmination of a few weeks of work and experimentation around the
expo-threeandthree.jsecosystems. @Jpoliachik and I were able to get many more examples running in the example app and lots of upgrades to bring this library back into line with the latest expo standards and SDK.Here are the updates in no particular order:
expo-threeinstead of the build directory, making developing on the example app much easier without the build service running.expo-threeto use the latestexpo-module-scriptsexpo-three-orbit-controls(had to patch because it still relies on an old version of THREE).The example app works on android and web, but I haven't tested on iOS because the simulator doesn't support web-gl.
All tests pass (including the new ones!)
Please let me know what else needs to be done to get this merged!
This PR will Close: #164, #199, #212, #238, #270, #287, #297, #298, & #299
Thanks to @Jpoliachik for his help in getting this branch working and for porting over some THREE web examples over from the web examples.