-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[video-thumbnails][Android] Fix a crash when the source cannot be retrieved #28961
Merged
tsapeta
merged 10 commits into
expo:main
from
mrakesh0608:fix/expo-video-thumbnails-crash-on-bad-uri
May 20, 2024
Merged
[video-thumbnails][Android] Fix a crash when the source cannot be retrieved #28961
tsapeta
merged 10 commits into
expo:main
from
mrakesh0608:fix/expo-video-thumbnails-crash-on-bad-uri
May 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrakesh0608
changed the title
fix: expo-video-thumbnails crash on bad uri
[expo-video-thumbnails][Android] fix: crash on bad uri
May 18, 2024
expo-bot
added
bot: passed checks
ExpoBot has nothing to complain about
and removed
bot: suggestions
ExpoBot has some suggestions
labels
May 18, 2024
tsapeta
reviewed
May 18, 2024
apps/native-component-list/src/navigation/ExpoComponentsStackNavigator.tsx
Outdated
Show resolved
Hide resolved
apps/native-component-list/src/screens/ExpoComponentsScreen.tsx
Outdated
Show resolved
Hide resolved
apps/native-component-list/src/screens/VideoThumbnailsScreen.tsx
Outdated
Show resolved
Hide resolved
apps/native-component-list/src/screens/VideoThumbnailsScreen.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Tomasz Sapeta <tomasz.sapeta@me.com>
Co-authored-by: Tomasz Sapeta <tomasz.sapeta@me.com>
Co-authored-by: Tomasz Sapeta <tomasz.sapeta@me.com>
tsapeta
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the contribution!
tsapeta
changed the title
[expo-video-thumbnails][Android] fix: crash on bad uri
[video-thumbnails][Android] Fix a crash when the source cannot be retrieved
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #27936
How
sourceFilename
.sourceFilename
is valid, but the retriever can't load it due to a bad URI, then it throws an errorsetDataSource failed: status = 0x80000000
. To handle this, a catch handler is added.Test Plan
Tested using bare-expo.
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).