This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Remove mentions to asyncreserved keyword for usage with Python 3.7
#135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in python37, async is a reserved word, so I changed it
This was referenced Nov 6, 2019
removed a runaway '=True'
douglasrizzo
force-pushed
the
fix_async
branch
from
0b76b73
to
fe06f56
Compare
|
Any updates on this? |
|
I don't think this project is still active. If you want to use this PR, you can fork the repo and apply the PR to your fork. Or just clone my fork, where I fixed this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I've deleted all mentions to the
asynckeyword in the master branch of ELF to resume compatibility of the repository with Python 3.7ELF uses
asyncas a name for variables and function parameters. In Python 3.7,asynchas become a reserved word. The word is only used as argument to thecopy_andcudamethods, which are methods from thepytorch.Tensorobject. But these methods don't use the value of theasyncargument for anything.By removing mentions to the now-reserved keyword, no change in the behavior of the package is expected. I've tested training a model using
./train_minirts.shon Python 3.7 with both CPU and GPU and everything worked. I believe this fixes #124 and #127.I created a new PR because I used my master branch as the head repository in #134, which was a bad idea on my side.