Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handled edge case for processing []byte in abi + Update gRPC calls #132

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

yongkangchia
Copy link

@yongkangchia yongkangchia commented Apr 23, 2024

Problems:

  • Error: Missing bytes[] handling for ABI GetPaddedParams
  • Tests failing
  • Missing gRPC for GetEnergyPrices & GetBandwidthPrices

#131
#134

Solution:

  • Added fixes for bytes[] handling
  • Added tests for multiple edge cases
  • Fixed Tests for GetAccount
  • Add GetEnergyPrices & GetBandwidthPrices + tests

Note:

  • Usually in LoadFromJson, the expected output is type string. Therefore GetPaddedParams will take in type string in most cases.
  • However there are some cases when calling GetPaddedParams directly that the type will be of interface. Therefore the code has handles for different types.

@yongkangchia yongkangchia changed the title Handled edge case for processing []byte in abi Handled edge case for processing []byte in abi + Update gRPC calls May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant