Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth, android): allow nullable accessToken when creating OAuthProvider #12795

Merged
merged 1 commit into from
May 21, 2024

Conversation

russellwheatley
Copy link
Member

Description

OAuthProvider can have a null access token, this makes behaviour consistent across web, apple and android.

Related Issues

fixes #12791

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@meihdimtg
Copy link

I have a problem, registering a user with an email password and a custom token, except that this changed 1 month ago, no one can register on my application anymore, but on the web side it works.

However, the Firebase keys work correctly, the json files are in the root, I have an internal error, MISSING IDENTIFIER however the token returned by my api works for the NEXT JS version which has the same token as that of the app except that via the application and the flutter firebase_auth package this no longer works.

@russellwheatley russellwheatley merged commit 490319d into master May 21, 2024
20 of 23 checks passed
@russellwheatley russellwheatley deleted the auth-12791 branch May 21, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIIREBASE_AUTH] Unable to establish connection on channel.
4 participants