Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for 7 byte uid #19

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

dsl400
Copy link

@dsl400 dsl400 commented Jul 8, 2020

a quick hack to read the 7 byte UID

documentation:
page 4 describes how it works
https://www.nxp.com/docs/en/application-note/AN10927.pdf
page 32 contains the instruction set bytecodes
https://www.nxp.com/docs/en/data-sheet/NTAG213_215_216.pdf

@firsttris
Copy link
Owner

firsttris commented Jul 8, 2020

hey @dsl400 thx for your work, i appreciate your contribution.

a suggestions to your code base:
From my knowledge i think you should use "let" only if you want to re-assign new values to a variable after its declaration.
I think in most cases you can use "const".

some variables where you really need "let" => "select", "uidCheck"

regards
Tristan

@dsl400
Copy link
Author

dsl400 commented Jul 8, 2020

it is just a quick hack
thanks for the feedback :)

@trgraglia
Copy link

Hi @dsl400 , I have implemented the changes and it does not currently work for a MIFARE DESFire EV2 which is also a 7 byte UID. Was this code working for you with other NFCs with 7 byte UIDs? Was this change "complete"?
Thanks

@dsl400
Copy link
Author

dsl400 commented Aug 24, 2021

Hi @dsl400 , I have implemented the changes and it does not currently work for a MIFARE DESFire EV2 which is also a 7 byte UID. Was this code working for you with other NFCs with 7 byte UIDs? Was this change "complete"?
Thanks

I have no Ideea if it works with MIFARE DESFire EV2, you will have to consult the documentation and see if it needs any changes, just like I did

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants