change of inkstroke modeler #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cargo.toml change - API change (usize for n_steps, no PredictionParams and no tilt or orientation)
To match the changes in the stroke modeler
Doublonmousse
commented
May 31, 2024
|
Uh now I have issues when I pause the stroke and continue moving later. Edit : fixed |
flxzt
reviewed
Jun 7, 2024
|
Tested on my X1-Yoga and my desktop PC and I have found no issues or differences in behaviour to pre-rewrite. Looks good to me! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the rnote side :
On the inkstroke modeler side
This rewrite is mostly to have something that's easier to build/compile from rust on all platforms.