upgrade DHT11/DHT22 backing library #297
Merged
+61
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old DHT11/DHT22 backing library Adafruit_DHT is out of maintained and reporting error on my rpi4+python311. ` ImportError: cannot import name 'Raspberry_Pi_2_Driver' from 'Adafruit_DHT'` And it has CPU usage hogging problem (~25%). Upgrade DHT11/DHT22 backing library to adafruit-circuitpython-dht
|
Haven't checked that already, but why did you changed mqtt_io/modules/sensor/bmp085.py for the DHT22/11? If this is another (new) sensor you should seperate your Pull Requests. |
|
Yes, it's a combo PR, I will make it seperated, thanks. |
|
Thanks! |
|
What's happend with this pull request? The current DHT22 code isn't functional and it looks like this pull request would fix that, it just needs the code for bmp085 separated out. I can submit a new pull request just for DHT22 if that would be helpful? |
|
I would highly appreciate that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old DHT11/DHT22 backing library Adafruit_DHT is out of maintained and reporting error on my rpi4+python311.
ImportError: cannot import name 'Raspberry_Pi_2_Driver' from 'Adafruit_DHT'And it has CPU usage hogging problem (~25%).
Upgrade DHT11/DHT22 backing library to adafruit-circuitpython-dht