Serial Stream with HA and message delimiter #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jtkDvlp, could you please add an example configuration for your extended config input? |
|
Hi @BenjiU, hopefully the added example config helps. Best Regards |
|
Mmh does anyone known, why the CI does not accept the return type? It seems to be correct for me, None or byte array. 🤔 |
BenjiU
reviewed
Feb 26, 2024
| if data: | ||
| data = data[:-len(self.config["delimiter"])] | ||
| else: | ||
| data = self.ser.read(self.ser.in_waiting) or None |
There was a problem hiding this comment.
@jtkDvlp I guess this is the problem:
read has to return Optinal[bytes], but in line 107 it may return "None" (or with the preset in line 98)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.