Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browser/device context to billboards #20953

Merged
merged 9 commits into from
May 23, 2024

Conversation

benhalpern
Copy link
Contributor

@benhalpern benhalpern commented May 13, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

This is a continuation of #20680 which I'm closing because it fell behind main.

Allow billboards to target a browser context (i.e. desktop browser, mobile browser, in-app browser). We could add other specific targeting to the list in the future (i.e. tablet, etc. IOS/Android, Mac/Windows) if we have that need, but keeping it to simple use cases for now.

Related Tickets & Documents

Copy link
Contributor

github-actions bot commented May 13, 2024

Uffizzi Preview deployment-52204 was deleted.

@benhalpern benhalpern marked this pull request as ready for review May 23, 2024 19:03
@benhalpern benhalpern requested review from a team as code owners May 23, 2024 19:03
@benhalpern benhalpern requested review from lightalloy and removed request for a team May 23, 2024 19:03
@benhalpern benhalpern merged commit fe1ffa8 into main May 23, 2024
31 of 32 checks passed
@benhalpern benhalpern deleted the ben/target-billboards-based-on-browser branch May 23, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Target billboards depending on user device type
1 participant