Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(curriculum): replace D.O.B. acronym in accessibility quiz #54829

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Supravisor
Copy link
Contributor

@Supravisor Supravisor commented May 16, 2024

Checklist:

Related to #47830

image

image

image

image

image

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label May 16, 2024
@Supravisor Supravisor marked this pull request as ready for review May 16, 2024 06:51
@huyenltnguyen huyenltnguyen added status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. labels May 16, 2024
@Supravisor
Copy link
Contributor Author

Is it okay for this PR to proceed without further changes?

Then the should fix can be applied on Question 1 and Question 2 using the sr-only class, in a separate PR.
Otherwise another issue may need to merge into this one.

@bbsmooth
Copy link
Contributor

bbsmooth commented Jun 3, 2024

Is it okay for this PR to proceed without further changes?

I would vote no.

"Although the Date of Birth text is descriptive, it can be problematic for visually impaired users."

This doesn't make sense. Date of Birth is not problematic for visually impaired users. Also, you wouldn't add visually hidden text that is exactly the same as the visible text. That's just unnecessary duplication for screen reader users.

It's not just a matter of changing D.O.B to Date of Birth. This entire step needs to be reworked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants