Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WiP] Migrate from SDL2 -> SDL3 #529

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

[WiP] Migrate from SDL2 -> SDL3 #529

wants to merge 7 commits into from

Conversation

manio
Copy link
Contributor

@manio manio commented Jan 30, 2024

Hi,
I think that sooner or later you'll eventually migrate this project to SDL3.

I've started this process by following official migrate guide:
https://wiki.libsdl.org/SDL3/README/migration

Current stage is that it is compiling and linking against SDL3 library.
I just want to share my work as I don't know if and when I'll eventually fix all problems.

Last commit is still a big WiP. The game is trying to initialize but it is entering into 100% cpu load and outputing:

[...]
Info: [video] Initialized with SDL 3.0.0 (driver: wayland)
wp_viewport@49: error 0: wl_viewport.set_source sent with invalid values

Edit: This is now fixed :)

I am testing this in wayland.

src/savegame.cc Outdated Show resolved Hide resolved
@wdigger
Copy link
Member

wdigger commented Jan 30, 2024

Good idea!

It would probably be more convenient to make a fork for this, but if you are comfortable enough with MR, you are welcome )

This reverts commit f9b03ca.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants