Create tempdir in test using t.TempDir() #4851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sigh. Windows… It might just be a case of some readers not being closed but of course you’ll have to fal the whole test for that. I’ll have a look tomorrow |
andydotxyz
reviewed
May 21, 2024
andydotxyz
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Go 1.18 introduced the .TempDir() method for automatically creating temporary directories in tests that then are removed automatically at the end of the tests. use that instead of the functions in the os package.
This change initially introduced errors that then turned out to be cases of actual bugs where we did not close file handles.
Checklist: