Workaround for https://github.com/LedgerHQ/app-ethereum/issues/409 #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
prestwich
changed the title
|
now ready for review 🖖 |
prestwich
commented
Feb 25, 2023
| // workaround for https://github.com/LedgerHQ/app-ethereum/issues/409 | ||
| // TODO: remove in future version | ||
| let chunk_size = | ||
| (0..=255).rev().find(|i| payload.len() % i != 3).expect("true for any length"); |
There was a problem hiding this comment.
finds the largest chunk size that does not leave 3 hanging bytes on the payload lol
prestwich
force-pushed
the
prestwich/ledger-signer-workaround
branch
from
2ece0a5
to
b1ec9ce
Compare
gakonst
approved these changes
Feb 27, 2023
| // workaround for https://github.com/LedgerHQ/app-ethereum/issues/409 | ||
| // TODO: remove in future version | ||
| let chunk_size = | ||
| (0..=255).rev().find(|i| payload.len() % i != 3).expect("true for any length"); |
Comment on lines
+238
to
+239
| guard.record("index", index); | ||
| guard.record("chunk", hex::encode(chunk)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes chunk size dynamic to avoid running into this:
LedgerHQ/app-ethereum#409
Motivation
foundry-rs/foundry#4362
Solution
PR Checklist