Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dashboard url in external labels #9793

Closed
wants to merge 1 commit into from

Conversation

neo-liang-sap
Copy link
Contributor

How to categorize this PR?
/area monitoring

What this PR does / why we need it:
based on some discussion with @vicwicker i'm adding dashboard url into external labels field, might also be valuable for the open source users so that they can easily add links to the dashboard in their alert descriptions if they want to
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

add dashboard url in external labels

@gardener-prow gardener-prow bot added area/monitoring Monitoring (including availability monitoring and alerting) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 20, 2024
@gardener-prow gardener-prow bot requested a review from ary1992 May 20, 2024 04:58
Copy link
Contributor

gardener-prow bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign timebertt for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot requested a review from rfranzke May 20, 2024 04:58
@neo-liang-sap
Copy link
Contributor Author

/retest-required

@neo-liang-sap
Copy link
Contributor Author

@vicwicker do you have any idea why some test are failing? from error msg i just saw sth like shoot can't be reconciled but unable to find any relation with my pr code change

@shafeeqes
Copy link
Contributor

/retest

1 similar comment
@neo-liang-sap
Copy link
Contributor Author

/retest

@vicwicker
Copy link
Contributor

Oh I am sorry @neo-liang-sap but I had an internal discussion with @istvanballok about this and he made a point that adding the URL as external label would be adding it everywhere (i.e., also for all metrics) which is not desired. We only need it for the alerts so I started preparing a different change to achieve this using alert_relabel_reconfigs but I didn't open a PR yet.

Unfortunately, I don't think we are going to go this route. I am very sorry I forgot to mention this in our previous chat.

@neo-liang-sap
Copy link
Contributor Author

@vicwicker no problem, thanks for the message! so i will close this PR, right?

@vicwicker
Copy link
Contributor

vicwicker commented May 21, 2024

@neo-liang-sap Yes, please. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring Monitoring (including availability monitoring and alerting) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants