-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dashboard url in external labels #9793
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
@vicwicker do you have any idea why some test are failing? from error msg i just saw sth like shoot can't be reconciled but unable to find any relation with my pr code change |
/retest |
1 similar comment
/retest |
Oh I am sorry @neo-liang-sap but I had an internal discussion with @istvanballok about this and he made a point that adding the URL as external label would be adding it everywhere (i.e., also for all metrics) which is not desired. We only need it for the alerts so I started preparing a different change to achieve this using Unfortunately, I don't think we are going to go this route. I am very sorry I forgot to mention this in our previous chat. |
@vicwicker no problem, thanks for the message! so i will close this PR, right? |
@neo-liang-sap Yes, please. Thanks a lot! |
How to categorize this PR?
/area monitoring
What this PR does / why we need it:
based on some discussion with @vicwicker i'm adding dashboard url into external labels field,
might also be valuable for the open source users so that they can easily add links to the dashboard in their alert descriptions if they want to
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: