Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gardenlet: Do not deploy blackbox-exporter for Shoots with .spec.purpose=testing #9796

Merged

Conversation

ialidzhikov
Copy link
Member

How to categorize this PR?

/area monitoring
/kind regression

What this PR does / why we need it:
After #9695, Shoots with spec.purpose=testing are unhealthy with:

Deployment "shoot--foo--bar/blackbox-exporter" is unhealthy: condition "Available" has invalid status False (expected True) due to MinimumReplicasUnavailable: Deployment does not have minimum availability.
% k -n shoot--foo--bar get po -l app=blackbox-exporter
NAME                                 READY   STATUS              RESTARTS   AGE
blackbox-exporter-6dd585c5cf-j8z2w   0/1     ContainerCreating   0          21m
blackbox-exporter-6dd585c5cf-k89n8   0/1     ContainerCreating   0          46m
% k -n shoot--foo--bar describe po blackbox-exporter-6dd585c5cf-j8z2w

  Warning  FailedMount       19s (x18 over 20m)  kubelet                MountVolume.SetUp failed for volume "cluster-access" : secret "shoot-access-prometheus-shoot" not found

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
N/A

Release note:

gardenlet: An issue causing the blackbox-exporter Deployment to be created and to be unhealthy in the Shoot control plane for Shoots with `.spec.purpose=testing` is now fixed.

@gardener-prow gardener-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2024
Copy link
Contributor

gardener-prow bot commented May 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added area/monitoring Monitoring (including availability monitoring and alerting) related kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels May 20, 2024
@gardener-prow gardener-prow bot requested review from ary1992 and timuthy May 20, 2024 08:21
@gardener-prow gardener-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 20, 2024
@ialidzhikov ialidzhikov marked this pull request as ready for review May 20, 2024 09:38
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2024
@ialidzhikov
Copy link
Member Author

/cherry-pick release-v1.95

@gardener-ci-robot
Copy link
Contributor

@ialidzhikov: once the present PR merges, I will cherry-pick it on top of release-v1.95 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.95

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@AleksandarSavchev AleksandarSavchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally.
/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
Copy link
Contributor

gardener-prow bot commented May 20, 2024

LGTM label has been added.

Git tree hash: 0e9153c4cd1a44c60261a5ee12d045c9f01ea7d3

@ialidzhikov
Copy link
Member Author

/approve

Copy link
Contributor

gardener-prow bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AleksandarSavchev, ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2024
@gardener-prow gardener-prow bot merged commit 1f03ede into gardener:master May 20, 2024
18 checks passed
@gardener-ci-robot
Copy link
Contributor

@ialidzhikov: new pull request created: #9798

In response to this:

/cherry-pick release-v1.95

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rfranzke
Copy link
Member

Thanks for this fix @ialidzhikov, appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/monitoring Monitoring (including availability monitoring and alerting) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants