add Git as agents' source control tool #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekan
reviewed
Aug 2, 2023
metagpt/roles/engineer.py
Outdated
| @@ -57,6 +58,7 @@ def __init__(self, name="Alex", profile="Engineer", goal="Write elegant, readabl | |||
| self._watch([WriteTasks]) | |||
| self.todos = [] | |||
| self.n_borg = n_borg | |||
| logger.info(f"---> init Egineer: {self._role_id}, {self._setting.name}") | |||
metagpt/actions/design_api.py
Outdated
| @@ -106,18 +107,23 @@ def recreate_workspace(self, workspace: Path): | |||
| def _save_prd(self, docs_path, resources_path, prd): | |||
| prd_file = docs_path / 'prd.md' | |||
| quadrant_chart = CodeParser.parse_code(block="Competitive Quadrant Chart", text=prd) | |||
| mermaid_to_file(quadrant_chart, resources_path / 'competitive_analysis') | |||
| quadrant_chart_file = resources_path / 'competitive_analysis' | |||
There was a problem hiding this comment.
这个逻辑实现错了，实际的后缀是在mermaid_to_file中决定的
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable agents to use Git for version control after writing files to track the project development process. Currently, the implementation immediately adds and commits changes after writing files. However, there is a potential issue with the
git add & commitoperation for thesave_prdoperation inWriteDesign. Since it uses a subprocess to save files, there is a possibility that the files may not have been generated yet at the time of thegit add & commitoperation, potentially leading to omissions. This issue requires further investigation and resolution.