Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-libs/libtypec: add proxy-maint ebuild from GURU #36736

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

dev-libs/libtypec: add proxy-maint ebuild from GURU #36736

wants to merge 1 commit into from

Conversation

10ne1
Copy link
Contributor

@10ne1 10ne1 commented May 18, 2024

I've been maintaining this ebuild in GURU together with Rajaram, the upstream libtypec project maintainer landing various fixes.

We believe v0.5.1 has reached a clean state with no required backport patches and would like to proxy maintain it into the main Gentoo repo.

Once this lands in the main repo, we will remove it from GURU.

Please check all the boxes that apply:

  • I can submit this contribution in agreement with the Copyright Policy.
  • I have certified the above via adding a Signed-off-by line to every commit in the pull request.
  • This contribution has not been created with the assistance of Natural Language Processing artificial intelligence tools, in accordance with the AI policy.
  • I have run pkgcheck scan --commits --net to check for issues with my commits.

Please note that all boxes must be checked for the pull request to be merged.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @10ne1
Areas affected: ebuilds
Packages affected: dev-libs/libtypec

dev-libs/libtypec: @gentoo/proxy-maint (new package)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

New packages

This Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels May 18, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-05-18 20:40 UTC
Newest commit scanned: 97413fe
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b258e9cc19/output.html

@10ne1 10ne1 force-pushed the dev/aratiu/add-libtypec-from-guru branch from 97413fe to 28c9df8 Compare May 20, 2024 15:18
@10ne1
Copy link
Contributor Author

10ne1 commented May 20, 2024

Thank you @mattst88 I think I addressed all your feedback and also added the upstream patch.

@10ne1 10ne1 force-pushed the dev/aratiu/add-libtypec-from-guru branch 2 times, most recently from 1d6a46b to 8f926dc Compare May 20, 2024 16:02
@mattst88
Copy link
Contributor

We believe v0.5.1 has reached a clean state with no required backport patches and would like to proxy maintain it into the main Gentoo repo.

For such a small library, I'd really like to see no patches in ::gentoo, especially given the amount of feedback I've provided and the difficulty in getting it resolved.

I'm still concerned that the library version is going to be incorrect in the future -- as it has been I believe every time I have looked at this package. With your meson.bulid patch I believe there are now 6 separate places where the package version is encoded:

  • CMakeLists.txt
  • utils/CMakeLists.txt
  • 3 times in meson.build
  • utils/meson.build

@mattst88
Copy link
Contributor

pixman sets MAJOR/MINOR/PATCH based on the package version like this:

version_conf = configuration_data()
split = meson.project_version().split('.')
version_conf.set('PIXMAN_VERSION_MAJOR', split[0])
version_conf.set('PIXMAN_VERSION_MINOR', split[1])
version_conf.set('PIXMAN_VERSION_MICRO', split[2])

@10ne1
Copy link
Contributor Author

10ne1 commented May 20, 2024

Thanks @mattst88 for all your feedback.

I guess I'll have to continue maintaining it in GURU if you don't trust me to drop the patches after upstream lands them and creates a new release? 😄 Mind I've been doing this in GURU already.

In the meantime I'll pursue upstream to accept my patches.

Should I retry after a new upstream release is out containing the patches?

@mattst88
Copy link
Contributor

If you'd like to go ahead and get it into ::gentoo, let's land the cmake version since that worked, and when a new release is made that we can use without patches we'll switch to meson.

@10ne1 10ne1 force-pushed the dev/aratiu/add-libtypec-from-guru branch from 8f926dc to 8344bb1 Compare May 20, 2024 17:35
@10ne1
Copy link
Contributor Author

10ne1 commented May 20, 2024

Ok, I brought back cmake and will pursue fixing & moving to cmake for the next upsream release.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-05-20 18:01 UTC
Newest commit scanned: 8344bb1
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/52cc8057f9/output.html

@10ne1
Copy link
Contributor Author

10ne1 commented May 21, 2024

Sorry I meant moving to meson for the next release, because this is already using cmake :) should be ready to land.

Thank you for your patience!

@10ne1
dev-libs/libtypec: add proxy-maint ebuild from GURU
3dc863d 
I've been maintaining this ebuild in GURU together with Rajaram,
the upstream libtypec project maintainer landing various fixes.

We believe v0.5.1 has reached a clean state with no required
backport patches and would like to proxy maintain it into the
main Gentoo repo.

Once this lands in the main repo, we will remove it from GURU.

Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
@10ne1 10ne1 force-pushed the dev/aratiu/add-libtypec-from-guru branch from 8344bb1 to 3dc863d Compare May 21, 2024 07:02
@10ne1
Copy link
Contributor Author

10ne1 commented May 21, 2024

I also added dev-build/cmake to BDEPEND and moved virtual/pkgconfig there as well.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-05-21 07:25 UTC
Newest commit scanned: 3dc863d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3795d69321/output.html

gentoo-bot pushed a commit to gentoo/guru that referenced this pull request May 21, 2024
@10ne1
dev-libs/libtypec: split libtypec and libtypec-utils
87377ad 
And incorporate patches and feedback from Matt Turner [1].

We move the build to use meson as well as add 3 patches
to fix the upstream meson build [2]. I am in the process
of upstreaming these patches.

[1] gentoo/gentoo#36736
[2] libtypec/libtypec#1

Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
@10ne1
Copy link
Contributor Author

10ne1 commented May 21, 2024 •
edited

FYI: I added more patches to the upstream PR to fix the meson build: libtypec/libtypec#1

In the meantime I've also add the patches to GURU, moved the build there to meson, added a RDEPEND=!<dev-libs/libtypec-0.5.1-r1 and split the ebuild into libtypec and libtypec utils: gentoo/guru@87377ad

Once we get a new upstream release so I can drop the patches, I'll move the ebuild from ::gentoo to meson as well.

@10ne1
Copy link
Contributor Author

10ne1 commented May 22, 2024

FYI: upstream libtypec meson patches have landed, now I'll be waiting for an upstream release before switching to meson.

In the meantime please feel free to land this cmake version 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattst88 mattst88 mattst88 left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@10ne1 @gentoo-bot @gentoo-repo-qa-bot @mattst88