Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newer Request Tracker version #36737

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

timorl
Copy link

@timorl timorl commented May 19, 2024

This is my first PR to Gentoo so I'm mentally prepared for having done a lot wrong. Various thoughts in no particular order:

  1. This required adding two Perl modules and updating one.
  2. I wasn't sure whether to remove the previous version, so I didn't.
  3. I changed some use flags to support nginx. This feels a bit weird, since I was under the impression that www-apps usually don't specify which webserver they'll use for proxying, but I was trying to change as little as possible and earlier versions did that, so I kept (and expanded) it.
  4. I also mostly have an ebuild for 4.4.7 and if I knew how to do slots I would've probably included it in this PR as well (although I'm not sure it's worth it).
  5. I checked that this actually works, i.e. I am currently running a vhost+nginx instance of RT installed from this ebuild on my homeserver.
  6. I haphazardly bumped EAPI to 8 and only did one change resulting from pkgcheck complaining.
  7. Speaking of pkgcheck, it definitely doesn't give me a clean pass, but much of it doesn't seem to be caused by this PR.
  8. Although there is some stuff with keywords – I only added ~amd64 in most places, since this is the only one I actually tried running this on.
  9. This also fixes 920201 through the changes in the Makefile patch – the previous patch was doing approximately nothing, since the .NOTPARALLEL directive impacts how the dependencies of its arguments are run, not the arguments themselves. This could've possibly been a separate PR.
  10. Cleaned up the Perl dependencies by running the installation without them and seeing what it complains about. I think there are quite a couple in 4.4.4 that are unneeded, but too lazy to check and since I didn't touch that it's not my fault. :P

Please check all the boxes that apply:

  • I can submit this contribution in agreement with the Copyright Policy.
  • I have certified the above via adding a Signed-off-by line to every commit in the pull request.
  • This contribution has not been created with the assistance of Natural Language Processing artificial intelligence tools, in accordance with the AI policy.
  • I have run pkgcheck scan --commits --net to check for issues with my commits.

Please note that all boxes must be checked for the pull request to be merged.

timorl added 4 commits May 18, 2024 13:46
Signed-off-by: timorl <timorl@disroot.org>
Signed-off-by: timorl <timorl@disroot.org>
Signed-off-by: timorl <timorl@disroot.org>
Closes: https://bugs.gentoo.org/920201
Signed-off-by: timorl <timorl@disroot.org>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @timorl
Areas affected: ebuilds
Packages affected: dev-perl/DBIx-SearchBuilder, dev-perl/Data-Section-Simple, dev-perl/GraphViz2, www-apps/rt

dev-perl/DBIx-SearchBuilder: @gentoo/perl
dev-perl/Data-Section-Simple: @gentoo/proxy-maint (new package)
dev-perl/GraphViz2: @gentoo/proxy-maint (new package)
www-apps/rt: @titanofold, @gentoo/web-apps

Linked bugs

Bugs linked: 920201


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added new package The PR is adding a new package. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 19, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-05-19 09:55 UTC
Newest commit scanned: 970828b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b19ebac509/output.html

@titanofold titanofold self-assigned this May 19, 2024
@titanofold titanofold self-requested a review May 19, 2024 14:10
@titanofold
Copy link
Member

Thanks so much for getting this started! I was just talking about how I needed to get this packaged bump in gentoo-dev.

I do use RT at work in production for handling customer service emails, so I'm keen on getting this going.

There's a file that lists the modules needed. I'll dig into this today or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. new package The PR is adding a new package.
Projects
None yet
4 participants