[GEOT-7422] Adapt to GeoTools upgrade of java units "indriya" to version 2.2

[soc]

Companion change to geotools/geotools#4690.

Checklist

• I have read the contribution guidelines.
• I have sent a Contribution Licence Agreement (not required for small changes, e.g., fixing typos in documentation).
• First PR targets the main branch (backports managed later; ignore for branch specific issues).
• All the build checks are green (see automated QA checks).

For core and extension modules:

• New unit tests have been added covering the changes.
• Documentation has been updated (if change is visible to end users).
• The REST API docs have been updated (when changing configuration objects or the REST controllers).
• There is an issue in the GeoServer Jira (except for changes that do not affect administrators or end users in any way).
• Commit message(s) must be in the form [GEOS-XYZWV] Title of the Jira ticket.
• Bug fixes and small new features are presented as a single commit.
• Each commit has a single objective (if there are multiple commits, each has a separate JIRA ticket describing its goal).

[aaime]

This is not going to work. The units configuration is there to support reads too (see VariableAdapter usage in GeoTools), otherwise the class would be placed in netcdf-out.

However, I don't see why you can't use NetCDFUnitFormat directly, rather than creating NetCDFUnitFormatInstance (all it does is to create a second instance of the format, that is then being re-configured).

If mutability is the issue, thinking out loud, we could have a way to build a new NetCDFUnitFormat internal instance, and just throw away the old one: this way the unit format would be immutable, for as long as it lives. Just inform the callers not to cache the formatter instance, but always get it fresh from NetCDFUnitFormat.

[soc]

Thanks! You mean that we also use that instance from VariableAdapter then?

[aaime]

I mean the configuration file in GeoServer should affect also VariableAdapter parsing. In other words, the configuration is used also to parse NetCDF files with uncommon units, and not only to control the generation of new NetCDFs in the GeoServer output format.

[aaime]

Another thing I've noticed, gs-main won't build unless I control the unit-api dependency in the main GeoServer pom file, adding it to the dependency management.
Otherwise, the transitive dependency from systems.uom takes over and brings me back to an older version of javax.units, that does not have the QUETTA constant.

[soc]

Thanks, will try addressing these things!

[soc]

Reverted the undesired changes, added the unit-api dependency.

[aaime]

The changes look good but setAliases is private in the GeoTools PR.

Did you forget to push some changes over there?

[soc]

Not sure, but I updated the PR to keep them public, can you try again? :-)

[aaime]

Same as above, this is also private in the corresponding GeoTools PR.

[aaime]

Looks good, thanks, merging!