-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade maven-pmd-plugin to 3.22.0 which uses PMD 7 by default #7577
base: main
Are you sure you want to change the base?
Conversation
ba0e990
to
0c258f7
Compare
Nice one! Ambitious, too 🤣 |
This turns out to be much more work than anticipated, unfortunately I've no run out of time due to upcoming holiday, so this PR will stall from my side for a couple of weeks. Anyone willing to spend some time on it is quite welcome 🤣 |
Migrated a couple of modules while I was travelling. |
And a few more under "web" (but not all yet) |
And a few more fixes today. |
…EmptyIfStmt, EmptyInitializer, EmptyStatementBlock, EmptySwitchStatements, EmptySynchronizedBlock, EmptyTryBlock, and EmptyWhileStmt
Because I don't like scrolling
…llections, fix some try-with-resources
rebased and fixed merge conflicts |
Expanded the work to GWC: GeoWebCache/geowebcache#1279 |
This upgrades to the current release of the maven-pmd-plugin which uses PMD 7.0.0 by default.
While at it also update the build steps in the GH workflow
In 7.0.0 some rules have changed, this requires some changes in the selected rules.
As a result some PMD warnings are now triggered that need fixing.
Checklist
main
branch (backports managed later; ignore for branch specific issues).For core and extension modules:
[GEOS-XYZWV] Title of the Jira ticket
.