Allow different types of write #55
Conversation
Some devices are sensitive about the type of write performed. Add support for choosing whether or not a response is requested.
| try: | ||
| self._object.WriteValue( | ||
| bytes, | ||
| {'offset': dbus.UInt16(offset, variant_level=1)}, | ||
| {'offset': dbus.UInt16(offset, variant_level=1), | ||
| 'type': write_type}, |
There was a problem hiding this comment.
Thanks for your PR! It's important that we don't break existing projects using this library. Since this parameter was previously not specified, what is the default value of type if omitted?
There was a problem hiding this comment.
As I read the PR, the PR proposes the write_value() function to receive a new optional parameter with_response=True and thus existing code not providing that explicitly will get the default of True; in turn that will set write_type to "request" and that is then given to type if omitted.
So, that is the long story; and in short: existing code would with this PR default to 'type': "request" (as they will default to the with_response=True parameter.
| write_type = "request" | ||
| else: | ||
| write_type = "command" | ||
|
|
There was a problem hiding this comment.
write_type = 'request' if with_response else 'command'
might be more appropriate here, or if more explicit code is preferred:
if with_response:
write_type = 'request'
else:
write_type = 'command'
Some devices are sensitive about the type of write performed. Add support
for choosing whether or not a response is requested.