fix(ui): Add missing 'return' statement in <StructuredEventData /> #71148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a missing 'return' statement in the declaration of the <StructuredEventData /> component in 'static/app/components/structuredEventData/index.tsx'. Add a test to cover the corresponding use case (multiline strings).
github-actions
bot
added
the
Scope: Frontend
floels
commented
May 18, 2024
| </Wrapper>; | ||
| return ( | ||
| <Wrapper> | ||
| <ValueMultiLineString data-test-id="value-multiline-string"> |
There was a problem hiding this comment.
We also add a test id for the purpose of the test added in index.spec.tsx above.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #71148 +/- ##
=======================================
Coverage 77.87% 77.87%
=======================================
Files 6538 6538
Lines 291213 291213
Branches 50389 50389
=======================================
Hits 226792 226792
Misses 58184 58184
Partials 6237 6237
|
HazAT
approved these changes
May 23, 2024
lforst
added
the
Trigger: getsentry tests
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to add a missing
returnstatement in the declaration of the<StructuredEventData />component instatic/app/components/structuredEventData/index.tsx.Approach
We also add a test in the existing test file (
index.spec.tsx) to cover the corresponding use case (multiline strings). You can check that this test fails if you remove the fix inindex.tsx.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.