feat(trace): search using span. or transaction. entity prefix #71152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
JonasBa
changed the title
anonrig
reviewed
May 20, 2024
anonrig
approved these changes
May 20, 2024
Abdkhan14
approved these changes
May 21, 2024
Bundle ReportChanges will increase total bundle size by 398 bytes ⬆️
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables search by narrowing down on the entity types via span. and transaction. prefixes (errors, issues and autogroups still need to be implemented). Previously if two objects would had the same key, the value would be resolved from either of them and both were subject to match. With this change, searching narrows down on the entity by the prefix.
There is a slight annoyance with txns because they contain keys like
transaction.opas opposed to spans which only contain a key likeop, which is why we need to perform a direct lookup first, and only then look at the entity.