Use ScrollableContainer's bottomReached event to load more #3781
Conversation
|
@mtsgrd I've taken a look round at what the different methods of sending messages to children are, and in this case I thought the exported functions looked best, but I'm curious to know if you're aware of a better svelt-ey mechanism that I could use in this case. I did consider an BehaviourSubject in a context, but we've generally tried to keep RX.js internal to our services |
| // Make sure we display when the file list is reset | ||
| $: { | ||
| chunkedFiles = chunk(sortLikeFileTree(files), 100); | ||
| displayedFiles = chunkedFiles[0] || []; | ||
| currentDisplayIndex = 0; | ||
| } |
There was a problem hiding this comment.
Not sure how you feel here, but I prefer making a function for these things (to make it evident what the change detection depends on).
There was a problem hiding this comment.
That makes quite a bit of sense as a pattern 👍
|
A store could perhaps also work, but I like this solution, it feels like an appropriate and unsurprising way of doing it. |
Bit of a refactor over my async/await based gradual rendering. It was still struggling if you had in the neigherbourhood of 9000 files, so this will only render as the user scrolls down. There is still the issue of scrolling taking quite a long time, but it feels like the solution would need to be a floating commit button.
Caleb-T-Owens
force-pushed
the
improve-lazy-file-list
branch
from
a965b8e
to
b061537
Compare
Bit of a refactor over my async/await based gradual rendering.
It was still struggling if you had in the neigherbourhood of 9000 files, so this will only render as the user scrolls down.
There is still the issue of scrolling taking quite a long time, but it feels like the solution would need to be a floating commit button.