Update Terraform.gitignore to ignore .hcl file to be committed #4447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wirecat
requested changes
May 29, 2024
| @@ -32,3 +32,6 @@ override.tf.json | |||
| # Ignore CLI configuration files | |||
| .terraformrc | |||
| terraform.rc | |||
|
|
|||
| # Ignore hcl file | |||
| *.hcl | |||
There was a problem hiding this comment.
Could we call out the .terraform.lock.hcl file specifically?
If not, could you provide more external references to justify the more broad rule?
There was a problem hiding this comment.
yes we can call it as .terraform.lock.hcl instead of wildcard expresssion *.hcl.
shall i raise a new PR? please advice
There was a problem hiding this comment.
Updating this PR with the change is preferred in this situation. Thank you!
|
new pr raised here #4451 |
wirecat
added a commit
that referenced
this pull request
May 30, 2024
Update Terraform.gitignore to ignore .hcl files based on pr #4447
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change:
Making this change to ignore .terraform.lock.hcl which is an internal file generated by terraform and not needed in our remote repos as they are automatically generated on each terraform init runs
TODO
Links to documentation supporting these rule changes:
NA
TODO
If this is a new template:
existing template, just modified.
NA