Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New plugin: additional key shortcut [Ctrl+Shift+L] to clear all terminals at once #848

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jachoo
Copy link

@jachoo jachoo commented Oct 20, 2023

This simple plugin adds a new keyboard shortcut [Ctrl+Shift+L] which clears all visible terminals by sending [Ctrl+L] to each terminal.

@mattrose
Copy link
Member

Confined to plugin code:

Good Things: Isolated
Bad things: Unable to check to see whether Ctrl-Shift-L is already taken by another keybind. Do you know what happens in this case?

@mattrose mattrose added the question Further information is requested label Feb 17, 2024
@jachoo
Copy link
Author

jachoo commented Feb 23, 2024

If a key is already bound, it will be overridden, which could potentially lead to issues when unbinding. This is a general problem of binding keys in current implementation of plugin.KeyBindUtil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants