Refactor sha1 and time-limited code #31023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
added
topic/security
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
lunny
approved these changes
May 20, 2024
GiteaBot
added
lgtm/need 1
delvh
approved these changes
May 20, 2024
GiteaBot
added
lgtm/done
|
Pushed a new commit to improve tests 4c5aea1 , only test code is changed and improved. |
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
May 20, 2024
Remove "EncodeSha1", it shouldn't be used as a general purpose hasher (just like we have removed "EncodeMD5" in go-gitea#28622) Rewrite the "time-limited code" related code and write better tests, the old code doesn't seem quite right.
wxiaoguang
added a commit
that referenced
this pull request
May 20, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 21, 2024
* giteaofficial/main: Don't include link of deleted branch when listing branches (go-gitea#31028) [skip ci] Updated translations via Crowdin Refactor sha1 and time-limited code (go-gitea#31023) Return `access_denied` error when an OAuth2 request is denied (go-gitea#30974) Avoid 500 panic error when uploading invalid maven package file (go-gitea#31014) Fix incorrect "blob excerpt" link when comparing files (go-gitea#31013) Fix project column title overflow (go-gitea#31011) Fix data-race during testing (go-gitea#30999)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove "EncodeSha1", it shouldn't be used as a general purpose hasher (just like we have removed "EncodeMD5" in #28622)
Rewrite the "time-limited code" related code and write better tests, the old code doesn't seem quite right.