Fix for Inspector not running code in @tool scripts until restart #66381 #92099
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hilderin
force-pushed
the
fix_tool_script_not_running_until_restart
branch
from
8ba1180
to
ef6e94d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the problem where adding
@toolin a GDScript where there are getters and setters does not work until the editor is restarted #66381.I figured out that the problem was caused by creating a PlaceHolderInstance when the script is not a tool and nothing was converting it to a GDScriptInstance when adding
@tool. The inverse was probably also a problem when removing the@tool.It's my first time working with the GDScript, so I certainly missed something especially that my fix was real simple to implement. I did not test extensively.
I did not modify anything to fix the same issue with C# script. I'll wait your feedback before trying the same fix with C#.
@toolscripts until restart #66381.