Sample Return Codes #910
Open
Sample Return Codes #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or 1. Also fixed incorrect return at the end of main method of basic.cc.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thanks! I'm afraid we'll need a CLA (https://cla.developers.google.com/) before we can merge this though. |
|
Sorry for the delay @saran-t. I have completed the CLA, run the check again, and it has passed. |
saran-t
approved these changes
Jun 14, 2023
saran-t
reviewed
Jun 14, 2023
| @@ -284,7 +284,7 @@ int main(int argc, char** argv) { | |||
| // print help if not enough arguments | |||
| if (argc<2) { | |||
| std::printf("\n Arguments: modelfile [nthread niter nwarmup nepoch nstep eps]\n\n"); | |||
| return 1; | |||
| return EXIT_FAILURE; | |||
There was a problem hiding this comment.
You chose to return EXIT_SUCCESS for the equivalent branch ("print help") in the other programs, so let's do that here too.
saran-t
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified samples to return EXIT_SUCCESS OR EXIT_FAILURE instead of 0 or 1. Also fixed incorrect return at the end of main method of basic.cc.