Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for libtorch 2.0 #1219

Merged
merged 3 commits into from May 13, 2024
Merged

Update for libtorch 2.0 #1219

merged 3 commits into from May 13, 2024

Conversation

tacertain
Copy link
Contributor

@tacertain tacertain commented Apr 28, 2024 •
edited

PyTorch 2.0 deprecated passing a int-valued mask to masked_fill. This change updates one usage in dqn.cc to use bools.

This commit fixes issue #1216

@tacertain
Update for libtorch 2.0
c07251f 
PyTorch 2.0 deprecated passing a int-valued mask to masked_fill.
This change updates one useage in dqn.cc to use bools.
@google-cla Google CLA
Copy link

google-cla bot commented Apr 28, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lanctot
Copy link
Collaborator

lanctot commented Apr 29, 2024

Nice!!!

Thanks so much for digging into this!

@lanctot
Copy link
Collaborator

lanctot commented Apr 29, 2024

Two questions:

  1. What version of LibTorch did you use? Should we update the link here to refelct a newer version?
  2. Did you run into the pybind11 conflict mentioned on line 86 of the global_variables.sh file linked in (1), or is that now "fixed" as a result of using a newer version of libtorch (issue Cannot Compile with libtorch #966 )?

@tacertain
Copy link
Contributor Author

  1. Sure - I'll add that to the PR
  2. I did run into that issue and fixed it the same way - I didn't spend any time looking whether there was a better fix.

@tacertain
Update global_variables.sh
f8d7fba 
Use correct URL for Linux and clean up the language in the instructions for what it does.
@tacertain
Copy link
Contributor Author

Third time's a charm?

@lanctot lanctot added imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! merged internally The code is now submitted to our internal repo and will be merged in the next github sync. labels May 1, 2024
@lanctot lanctot merged commit 9ecde1f into google-deepmind:master May 13, 2024
12 checks passed
@lanctot lanctot mentioned this pull request May 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanctot lanctot lanctot left review comments

Assignees
No one assigned
Labels
imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! merged internally The code is now submitted to our internal repo and will be merged in the next github sync.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tacertain @lanctot