-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[db/v1/instances] add access field - trove database dbaas #2876
base: master
Are you sure you want to change the base?
[db/v1/instances] add access field - trove database dbaas #2876
Conversation
@EmilienM Hi, Could you review these changes? I just added new field - Access. Without methods specific for that field, e.g.:
And decided to use the value for Access struct instead of pointers as described below. |
Issue
Fixes #2878
Description
AccessOpts
structAccessOpts
forAccess
field inCreateOpts
- like a value, not pointer - OK?Links
InstanceController.create: https://github.com/openstack/trove/blob/40fdb7b44fb33e022b77ba8df63fde2565c70dea/trove/instance/service.py#L366
InstanceController.update: https://github.com/openstack/trove/blob/40fdb7b44fb33e022b77ba8df63fde2565c70dea/trove/instance/service.py#L581
Related: