Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Makefile for CI jobs #3046

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Use Makefile for CI jobs #3046

wants to merge 8 commits into from

Conversation

stephenfin
Copy link
Contributor

@stephenfin stephenfin commented May 8, 2024 •
edited

Start using the Makefile added in #2940 for our CI jobs.

Depends-on: #3064

@EmilienM
Copy link
Contributor

EmilienM commented May 8, 2024

awesome! thanks

@github-actions github-actions bot added the semver:patch No API change label May 8, 2024
@coveralls
Copy link

coveralls commented May 8, 2024 •
edited

Coverage Status

coverage: 63.474% (-15.2%) from 78.682%
when pulling d6e6ded on stephenfin:use-makefile-in-ci
into 3b144ad on gophercloud:master.

@github-actions github-actions bot removed the semver:patch No API change label May 15, 2024
@stephenfin stephenfin marked this pull request as ready for review May 15, 2024 14:44
@github-actions github-actions bot added the semver:patch No API change label May 15, 2024
@github-actions github-actions bot added semver:patch No API change and removed semver:patch No API change labels May 20, 2024
@github-actions github-actions bot added semver:patch No API change and removed semver:patch No API change labels May 21, 2024
@github-actions github-actions bot added semver:patch No API change and removed semver:patch No API change labels May 22, 2024
EmilienM
EmilienM previously approved these changes May 22, 2024
View reviewed changes
@stephenfin
Copy link
Contributor Author

stephenfin commented May 22, 2024 •
edited

@EmilienM The failures of the functional-baremetal job on the master branch looks real and seems like we're not passing through OS_SYSTEM_SCOPE correctly. I'm trying to figure out why now (by increasing verbosity of the stackenv script, among other fixes).

EDIT: tbc, this is separate from the failures against stable/caracal, which are being addressed by #3052

@github-actions github-actions bot added semver:patch No API change and removed semver:patch No API change labels May 22, 2024
@EmilienM
Copy link
Contributor

@dtantsur FYI

@github-actions github-actions bot added semver:patch No API change and removed semver:patch No API change labels May 22, 2024
@github-actions github-actions bot added semver:patch No API change and removed semver:patch No API change labels May 22, 2024
@stephenfin
Copy link
Contributor Author

aaand of course the master job is passing now. Typical 🙄 There's a new failure but that seems to be an upper-constraint conflict

@github-actions github-actions bot added semver:patch No API change and removed semver:patch No API change labels May 23, 2024
@EmilienM
Copy link
Contributor

please rebase and this should be good to go after all your hard work, thanks again!

@github-actions github-actions bot added semver:patch No API change and removed semver:patch No API change labels May 28, 2024
@stephenfin stephenfin mentioned this pull request May 28, 2024
Merged
@stephenfin
Copy link
Contributor Author

@EmilienM The failures of the functional-baremetal job on the master branch looks real and seems like we're not passing through OS_SYSTEM_SCOPE correctly. I'm trying to figure out why now (by increasing verbosity of the stackenv script, among other fixes).

EDIT: tbc, this is separate from the failures against stable/caracal, which are being addressed by #3052

The issue turned out to be latent and I was simply exposing it by adding set -e to the script. I've fixed that separately in #3064 which should be merged first, after which I can rebase this.

@github-actions github-actions bot added semver:patch No API change and removed semver:patch No API change labels May 28, 2024
@stephenfin
tests: Search for compute service
bb70163 
It's more common than the object storage service.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@stephenfin
make: Correct typos
7dde9f9 
We mangled this, probably since we were renaming the 'imageservice'
module to 'image' at the time.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@stephenfin
make: Add 'acceptance-basic' target
fa4d24f 
For use in CI.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@stephenfin
make: Add timeout for acceptance tests
b584800 
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@stephenfin
CI: Switch to Makefile for running acceptance tests
1f4fe22 
We can remove the 'acceptancetest' script in the process. Note that this
isn't a 1:1 match: the fwaasv2 test job now runs the entire networking
test suite and not just the fwaasv2-specific tests but seeing as this is
using OVS rather than OVN that doesn't seem like such a bad thing.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@stephenfin
CI: Switch to Makefile for running linters
3921631 
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@stephenfin
CI: Switch to Makefile for running unit tests
3cac1c3 
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@stephenfin
script: Remove unused script
d6e6ded 
Users can use 'make unit' for this now.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@github-actions github-actions bot added semver:patch No API change and removed semver:patch No API change labels Jun 5, 2024
@EmilienM
Copy link
Contributor

EmilienM commented Jun 7, 2024 

Error: statfs /home/runner/.cache/golangci-lint/v1.57.1: no such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilienM EmilienM EmilienM left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
semver:patch No API change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stephenfin @EmilienM @coveralls