-
-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(packaging): add support for ipk package format #4863
base: main
Are you sure you want to change the base?
Conversation
@caarlos0 I'm not sure if GH will ping you on a draft PR so I'm mentioning you here to get some feedback when you get some time. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good, thank you!
for full transparency: I plan to release v2 as 1.26 minus the deprecations, so this will probably land in v2.1 only.
I'm aiming to release v2 either this weekend or the next, depending if I get any bug reports during this time
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4863 +/- ##
==========================================
+ Coverage 83.77% 83.78% +0.01%
==========================================
Files 135 139 +4
Lines 13029 11243 -1786
==========================================
- Hits 10915 9420 -1495
+ Misses 1677 1359 -318
- Partials 437 464 +27 ☔ View full report in Codecov by Sentry. |
Do you want me to update the doc to call out |
if you can yeah, I appreciate it! otherwise I can make the changes when the time comes :) |
Adds code to expose the ipk configuration values and registers the ipk package format with nfpm. Updates the documentation with how to use the new ipk specific configuration parameters.
@@ -1340,6 +1355,76 @@ func TestAPKSpecificScriptsConfig(t *testing.T) { | |||
}) | |||
} | |||
|
|||
// TODO: I need some help on advice to test the IPK specific code properly. It |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take a look when I have some time
looking good! thanks again for the pr, and for the patience 🙏 |
Adds code to expose the ipk configuration values and registers the ipk package format with nfpm.
Updates the documentation with how to use the new ipk specific configuration parameters.
This isn't ready to merge, but I have some questions
TestIPKSpecificConfig()
(code) from theTestAPKSpecificConfig()
and found it only is really testing if specific scripts are there or not. Since IPK doesn't have any additional scripts, just fields in one file do I need this test function? Is there a better way to validate the output?goreleaser
to be the org & repo - is there a way to override this in my fork without changing the code?ToNFPAlts()
andToNFP()
living in the config.go file ok? There wasn't much code in that file, so I figured I'd ask if you'd rather this code be elsewhere.