Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed link to '30 built-in components' in readme and quickstart markdowns #8331

Merged
merged 1 commit into from
May 20, 2024

Conversation

yvrjsharma
Copy link
Collaborator

Description

The hyperlink labeled 30 built-in components leads to a '404: Not found' error. This issue occurs in two locations:

This PR replaces the incorrect link with - https://www.gradio.app/docs/gradio/components

Closes: #(issue)

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@yvrjsharma yvrjsharma requested a review from abidlabs May 19, 2024 18:35
@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented May 19, 2024

🪼 branch checks and previews

Name Status URL
Website ready! Website preview
🦄 Changes detected! Details

@gradio-pr-bot
Copy link
Contributor

🦄 no changes detected

This Pull Request does not include changes to any packages.

__No changes detected. __

  • Maintainers can select this checkbox to manually select packages to update.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can create the changelog file directly.

Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @yvrjsharma!

@pngwn pngwn merged commit ffa2091 into main May 20, 2024
7 checks passed
@pngwn pngwn deleted the fix-readme-links branch May 20, 2024 12:29
@yvrjsharma
Copy link
Collaborator Author

Thanks @pngwn !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants