Scopes: Select scope even without data retrieval #87988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfmatei
added
area/dashboard
no-changelog
dprokop
approved these changes
May 29, 2024
| @@ -43,7 +43,7 @@ export interface Prometheus extends common.DataQuery { | |||
| * Returns a Range vector, comprised of a set of time series containing a range of data points over time for each time series | |||
| */ | |||
| range?: boolean; | |||
| scopes?: ScopeSpec[]; | |||
| scopes?: Array<ScopeSpec & Pick<Scope['metadata'], 'name'>>; | |||
There was a problem hiding this comment.
I wonder- why not passing Scope[] here, but plain spec with picked metadata.name? Scope is pretty much the same thing, but structured.
Comment on lines
80
to
+81
| type ScopeSpec struct { | ||
| Name string `json:"name"` // This is the identifier from metadata.name of the scope model. |
There was a problem hiding this comment.
Similar comment to the one above - I would expect promlib to utilise the apis' scope spec struct rather than re-writing the type. Is there a reason for that @kylebrandt / @bergquist ?
miguelmolina95
pushed a commit
to miguelmolina95/grafana
that referenced
this pull request
Jun 3, 2024
* Scopes: Select scope even without data retrieval * Pass entire scope and not only the spec to Prometheus * Enrich ScopeSpec that is sent to Prometheus * add name to BE --------- Co-authored-by: Kyle Brandt <kyle@grafana.com>
kminehart
pushed a commit
that referenced
this pull request
Jun 10, 2024
* Scopes: Select scope even without data retrieval * Pass entire scope and not only the spec to Prometheus * Enrich ScopeSpec that is sent to Prometheus * add name to BE --------- Co-authored-by: Kyle Brandt <kyle@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR allows a scope selection even if the scope details endpoint is not returning anything.
Why do we need this feature?
Sometimes there might not be details about a specific scope.
Who is this feature for?
Which issue(s) does this PR fix?:
Special notes for your reviewer:
Please check that: