-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting: Fix typo in JSON response for rule export. #88028
Conversation
This PR must be merged before a backport PR will be created. |
1 similar comment
This PR must be merged before a backport PR will be created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will fixing this cause issues with existing code? If it is new code... any reason to use a *string vs an empty string? Same for panelID... there is no panelID zero
No, this model is only used for export.
I think the only reason in this particular case, is to distinguish between specified field or not specified. In this model it's not necessary, and used for simpler conversion logic between models. |
(cherry picked from commit 8c2a382)
(cherry picked from commit 8c2a382)
No description provided.