Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): Fix ingester.ring.availability-zone missing issue #12980

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

HaibinZhang-Vungle
Copy link

@HaibinZhang-Vungle HaibinZhang-Vungle commented May 16, 2024

What this PR does / why we need it:
The parameter ingester.ring.availability-zone is missing or deprecated in the Loki image. When I tried deploy Loki 3.0.0 with Distributed mode, I got this error:

flag provided but not defined: -ingester.ring.instance-availability-zone
Run with -help to get list of available parameters

But the parameter used in statefulset-ingester-zone-a, statefulset-ingester-zone-b, statefulset-ingester-zone-c is:
'ingester.availability-zone'

So I changed the one in the template of 'statefulset-ingester' to 'ingester.availability-zone'

I have tested it on my testing environment on EKS cluster.

Helm version: v6.5.0
Loki version: v3.0.0

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Helm updates

@HaibinZhang-Vungle HaibinZhang-Vungle requested a review from a team as a code owner May 16, 2024 09:59
@CLAassistant
Copy link

CLAassistant commented May 16, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants